Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default menu option - 'Http' is not highlighted when launched from installed pwa app (UI bug) #100

Closed
NileshSP opened this issue Aug 30, 2019 · 5 comments
Closed

default menu option - 'Http' is not highlighted when launched from installed pwa app (UI bug) #100

NileshSP opened this issue Aug 30, 2019 · 5 comments
Assignees
@liyasthomas
Labels
bug Something isn't working

Comments

@NileshSP
Copy link
Contributor

Describe the bug
After launching pwa app from desktop, default 'Http' menu is not highlighted

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'postwoman.io'
  2. Click on 'Install PWA'
  3. Open Postwoman app from desktop
  4. 'Http' is not highlighted

Expected behavior

image

Desktop :

  • OS: Win 10
  • Browser chrome
  • Version latest
@NileshSP NileshSP changed the title default menu 'Http' is not highlighted when launched from installed pwa app (UI bug) default menu option - 'Http' is not highlighted when launched from installed pwa app (UI bug) Aug 30, 2019
@liyasthomas
Copy link
Member

Issue has been identified. Most probably its an issue with start URL of PWA. Will look into it ASAP.

@liyasthomas liyasthomas self-assigned this Aug 30, 2019
@liyasthomas liyasthomas added the bug Something isn't working label Aug 30, 2019
@NileshSP
Copy link
Contributor Author

Have found the issue after a bit of troubleshooting and have a solution, let me know if I can contribute by submitting a PR

@NBTX
Copy link
Contributor

NBTX commented Aug 30, 2019

@NileshSP go for it!

@NileshSP
Copy link
Contributor Author

@liyasthomas , @NBTX - submitted PR #125

liyasthomas added a commit that referenced this issue Sep 1, 2019
@liyasthomas
Merge pull request #125 from NileshSP/defaultmenuoptionhighlight
f3fa8d4 
update with PR for issue/bug #100
@liyasthomas
Copy link
Member

Fixed on #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liyasthomas liyasthomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liyasthomas @NileshSP @NBTX