Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal server environment usage requirements #336

Closed
FatDoge opened this issue Nov 25, 2019 · 7 comments · Fixed by #366
Closed

Internal server environment usage requirements #336

FatDoge opened this issue Nov 25, 2019 · 7 comments · Fixed by #366
Assignees
Labels
feature New feature or request

Comments

@FatDoge
Copy link

FatDoge commented Nov 25, 2019

Is your feature request related to a problem? Please describe.
When I deploy on an internal server,I noticed that the postwoman request css and icon from fonts.googleapis.com, but the internal server can not request the resources,so the layout become confusing.

Describe the solution you'd like
Wish the all resources can be used offline.

Describe alternatives you've considered
Just copy the css and icon from network ,put them into the dist and rewrite the code where import the other internet resources.

Additional context
微信图片_20191125154303.png

@FatDoge FatDoge changed the title Company intranet environment usage requirements Internal server environment usage requirements Nov 25, 2019
@FatDoge
Copy link
Author

FatDoge commented Nov 25, 2019

BTW, awesome project!

@liyasthomas
Copy link
Member

liyasthomas commented Nov 25, 2019

Actually this request was implemented quite a long ago, but I had to revert that on a critical error. Since you've mentioned this again, I'll fix it today itself.

And btw, it would be great if you gave credits to us or or atleast do not change the links to GitHub repo :)

@liyasthomas liyasthomas self-assigned this Nov 25, 2019
@liyasthomas liyasthomas added the feature New feature or request label Nov 25, 2019
@FatDoge
Copy link
Author

FatDoge commented Nov 25, 2019

Actually this request was implemented quite a long ago, but I had to revert that on a critical error. Since you've mentioned this again, I'll fix it today itself.

And btw, it would be great if you gave credits to us or or atleast do not change the links to GitHub repo :)

Of course~

@FatDoge
Copy link
Author

FatDoge commented Nov 26, 2019

If it is convenient, can you tell me where is the external network resource reference involved in packaging?
I mean the https://fonts.googleapis.com/css?family=Poppins:500,700|Roboto+Mono:400&display=swap and https://fonts.googleapis.com/icon?family=Material+Icons&display=swap
Wow, and I noticed that the resources refer the more resources...

@liyasthomas
Copy link
Member

I went quite busy, will make them available for offline ASAP.

@FatDoge
Copy link
Author

FatDoge commented Nov 26, 2019

Thanks a lot.
👍

@NBTX
Copy link
Contributor

NBTX commented Nov 28, 2019

@FatDoge I'm not sure if @liyasthomas has gotten around to making the resources offline, but for your own edification, the references to the resources are here:
https://github.com/liyasthomas/postwoman/blob/master/assets/css/fonts.scss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants