Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save to collections after deleting all the collections causes an error page #390

Closed
aksappy opened this issue Dec 2, 2019 · 2 comments · Fixed by #410
Closed

Save to collections after deleting all the collections causes an error page #390

aksappy opened this issue Dec 2, 2019 · 2 comments · Fixed by #410
Assignees
Labels
bug Something isn't working

Comments

@aksappy
Copy link

aksappy commented Dec 2, 2019

Describe the bug
When trying to save to collection, after deleting all the existing collection throws

this.$store.state.postwoman.collections[this.$data.requestData.collectionIndex] is undefined

To Reproduce
Steps to reproduce the behavior:

  1. Save a request to an existing collection.
  2. Delete all the existing collections
  3. Click on Save to Collections
  4. Error is seen, in addition to that neither "Go Home" or "Reload" does not work.

Expected behavior
Either say that there is no collection OR Save without a collection OR prompt for new collection

Screenshots

image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox
  • 70.0.1
@liyasthomas liyasthomas self-assigned this Dec 3, 2019
@liyasthomas liyasthomas added the bug Something isn't working label Dec 3, 2019
@ialexreis
Copy link
Contributor

I'm checking out this bug, and I detected that some array validation was missing.

Maybe this should be fixed with the recreation of a default collection "My Collection", in background or with a modal showing on the page, with the collection creation form.

What do you guys think is the best solution?

@ialexreis
Copy link
Contributor

@liyasthomas Implemented this validation, to prevent this bug from happenning..
Launching PR.

imagem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants