Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link to translations branch #737

Closed
gugacavalieri opened this issue Apr 4, 2020 · 7 comments
Closed

Broken link to translations branch #737

gugacavalieri opened this issue Apr 4, 2020 · 7 comments

Comments

@gugacavalieri
Copy link
Contributor

gugacavalieri commented Apr 4, 2020

Describe the bug

  • The link to the translations branch is broken on Readme
  • Is there still a translations branch? How can people contribute with translations?

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/liyasthomas/postwoman/blob/master/README.md
  2. Click on the link that says: All i18n contributions are welcome to i18n branch only!
  3. See error (404)

Expected behavior
I was wondering if the translation branch was deprecated.

Screenshots
image

Desktop (please complete the following information):

  • OS: Fedora 31
  • Google Chrome
  • Version 79.0.3945.130 (Official Build) (64-bit)
@liyasthomas
Copy link
Member

liyasthomas commented Apr 4, 2020

Hi there, sorry for the broken link. Fixed it.
Here's the link: https://github.com/liyasthomas/postwoman/tree/i18n

@gugacavalieri
Copy link
Contributor Author

Thanks @liyasthomas ! 👍

@gugacavalieri
Copy link
Contributor Author

I was just curious, did you make the i18n branch protected?

(maybe it was accidentally deleted)

@liyasthomas
Copy link
Member

Not protected at all. Can't you make the PR?

@gugacavalieri
Copy link
Contributor Author

actually you can do it only if you are one of the admins of the repo by going to Settings > Branches.

Here is the full guide:
https://help.github.com/en/enterprise/2.15/admin/developer-workflow/configuring-protected-branches-and-required-status-checks

😄

@liyasthomas
Copy link
Member

yes it is. You can make the PR to i18n branch.

@gugacavalieri
Copy link
Contributor Author

ah, cool! I will try then! Thanks @liyasthomas 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants