Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom functions #3

Open
offgridauthor opened this issue Aug 20, 2023 · 1 comment
Open

Add support for custom functions #3

offgridauthor opened this issue Aug 20, 2023 · 1 comment

Comments

@offgridauthor
Copy link

I love the p5.Polar library! I've been enjoying using it to make radially symmetric designs.

In my use, I added a function to allow for user-created shapes and designs in addition to the existing geometric ones (triangle, square, octagon, etc).

Simple example design

The function I added to my fork of this repo is here

Should I submit a PR for this, do you think? It's a slight departure from the existing design of the library, but it's something I could see people getting some benefit from as well, similar to the existing library's support for callbacks.

@liz-peng
Copy link
Owner

@offgridauthor Hi!! Sorry for the late response. I just merged a bug fix submitted by another contributor. Would you mind to fix your merge conflicts? I will take another look of your PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants