Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows path quoting problems #10

Open
oceandrama opened this issue Jul 26, 2023 · 5 comments
Open

Fix Windows path quoting problems #10

oceandrama opened this issue Jul 26, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@oceandrama
Copy link

Hi! Do you have any plans to release new major version as mentioned here https://github.com/ljharb/shell-quote/blob/main/test/quote.js#L38 to enable fix that was reverted in version 1.7.2 https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md#172

@ljharb
Copy link
Owner

ljharb commented Jul 26, 2023

No current plans, no. If this is functionality you need, we could add it behind an option?

@oceandrama
Copy link
Author

I think it could be possible solution for now

@ljharb
Copy link
Owner

ljharb commented Sep 21, 2023

Unfortunately I don't have any reference to https://github.com/substack/shell-quote/issues/37 so I'm not sure what necessitated the revert.

@oceandrama
Copy link
Author

144e1c2

@ljharb
Copy link
Owner

ljharb commented Sep 21, 2023

yep, but that doesn't tell me what the bug was :-)

altho i did find https://web.archive.org/web/20220310001817/https://github.com/substack/node-shell-quote/issues/37 so that's good :-)

I'd be happy to review a PR that restores the behavior under an option.

@ljharb ljharb added enhancement New feature or request help wanted Extra attention is needed labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants