Proposal - store generated object field value to generate depended fields

[yn-coder]

This is a proposal.

Right now I type

from elizabeth import Personal
p = Personal('en')
print( p.age() )
print( p.age() )

And got output

25
40

Because age is generated by request and doesn't store in object p. What if I want to add the field child_count or work experience, depend on previously generated age value?

[lk-geimfari]

from elizabeth import Personal
p = Personal('en')

saved_age = p.age(18, 25)
do_something(saved_age)

[yn-coder]

:)
I mean store in object.

[lk-geimfari]

I understand and i think that it's not good idea. We have to many methods in all providers.

[yn-coder]

SO lib should be used for generate for unrelated, noise data.
If so, then proposal is not usefull

[lk-geimfari]

@yn-coder You don't understand. Depended data is very cool, but i think that saving data in object is not good idea. We need something else.

[yn-coder]

Some cash?

[lk-geimfari]

@yn-coder Not yet.

[yn-coder]

@lk-geimfari

...but i think that saving data in object is not good idea.

Why? Can you explain?

[lk-geimfari]

@yn-coder Maybe I do not understand what you want.

You can try add your feature in your fork. If everything is okay we also add it to Elizabeth.

Maybe like that:

from elizabeth import Personal

p = Personal(locale='en', dependent=True)

Give us example of how it will work.

[yn-coder]

I read your examples of Elizabeth usage, and now I think I understood.

Person object doesn't contain the generated data because you design it just as wrapper for generator funcion. Person.age() yeld the new value each time and tester could use it in a loop, without creating the object instance for next person.

Now I see the root of our miscommunication.

I'll prepare a some example for my proposal in a fork.

[lk-geimfari]

Exactly!

[yn-coder]

This is a simple illustration for my idea in my fork

yn-coder@4fa723c

Code is not production ready, just a demo.

[lk-geimfari]

@yn-coder Generally it looks good.

But i think that this

    def __init__(self, locale='en'):
        """
        :param locale: Current language.
        """
        self.locale = locale
        self.data = pull('personal.json', self.locale)
        self.stored_age = 0

Should be:

    def __init__(self, locale='en'):
        """
        :param locale: Current language.
        """
        self.locale = locale
        self.data = pull('personal.json', self.locale)
        self._store = {'age': 0}

What do you think about it?

[lk-geimfari]

Now i see that it's can be really useful.

[yn-coder]

@lk-geimfari

What do you think about it?

You think self._store could be expanded for more parameters?

[lk-geimfari]

@yn-coder Yes, we can store in self._store other dependent data if we'll need.

[yn-coder]

yn-coder@d352188

[lk-geimfari]

@yn-coder Great! Please, check it with pycodestyle (or with similar tool) and send us PR.

[lk-geimfari]

Also don't forget about tests.

[yn-coder]

#109