Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Crashes when Deleting Last Trip #73

Open
lkellar opened this issue Jul 12, 2020 · 5 comments
Open

App Crashes when Deleting Last Trip #73

lkellar opened this issue Jul 12, 2020 · 5 comments
Labels
beta Related to betas of Apple OSs bug Something isn't working

Comments

@lkellar
Copy link
Owner

lkellar commented Jul 12, 2020

I've been fighting this bug for a couple hours, but I've got to go to bed and take a break, so logging it here so I don't forget.

Essentially, when deleting multiple trips (or one, not sure), and you delete the last one, it crashes.

One idea I just came up with, move the navigationlinks out of the list, put buttons as triphomerows there instead, do the ol selection/tag thing, see if that works.

I think part of the issue is that when there are zero trips, the part of the view hosting the tripdetail is going away, so it crashes.

Maybe also (a simpler thing), would be to put the add button thing there if there are zero trips, but not take away the host if there are zero, but just let it be empty and (hopefully) take up no space.

@lkellar lkellar added the bug Something isn't working label Jul 12, 2020
@lkellar lkellar added this to the 2020.2 Early iOS 14 Bugs milestone Jul 12, 2020
@lkellar
Copy link
Owner Author

lkellar commented Jul 12, 2020

Can confirm the simpler option DOES NOT CRASH (or appears not to). Only issue is the list takes up space even if there are no options.

THIS IS WHY TEMPLATEHOME DOESN"T HAVE THESE ISSUES.

@lkellar
Copy link
Owner Author

lkellar commented Jul 12, 2020

Maybe we go with the complex option, and store the navigation links somewhere in the VStack.
Would have to make them literally invisible/infinitely small

@lkellar
Copy link
Owner Author

lkellar commented Jul 12, 2020

This seems to be an iOS 14 bug!

@lkellar lkellar added the beta Related to betas of Apple OSs label Jul 12, 2020
@lkellar
Copy link
Owner Author

lkellar commented Jul 13, 2020

I think this is an OS error. I'll come back to this later in the summer

@lkellar lkellar removed this from the 2020.2 Early iOS 14 Bugs milestone Jul 13, 2020
@lkellar lkellar added this to the 2020.3 iOS 14 Release milestone Aug 11, 2020
@lkellar
Copy link
Owner Author

lkellar commented Sep 16, 2020

Lol, issue is still in gm. I'll have to make an elegant solution later. Still kinda rare that someone will be deleting all their trips one after the other. Adding a saveContext so that if it does crash, it'll save

@lkellar lkellar removed this from the 2020.3 iOS 14 Release milestone Sep 16, 2020
@lkellar lkellar added this to the 2021.2 iOS 15 Release milestone Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Related to betas of Apple OSs bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant