Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix & Memory leak fix #2

Open
turtleizzy opened this issue Nov 29, 2023 · 1 comment
Open

Bugfix & Memory leak fix #2

turtleizzy opened this issue Nov 29, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@turtleizzy
Copy link
Collaborator

turtleizzy commented Nov 29, 2023

There is a bug in __alloc_gpu (https://github.com/lkoshale/DA_STAR/blob/f17db9039e393f7b67956df51c579790bbd33f23/include/a_star.cu#L72C1-L72C40) rendering all sssp with starting node other than 0 fail to proceed.

Adding gpuErrchk ( cudaMemcpy(d_PQ,PQ,sizeof(unsigned int)*N,cudaMemcpyHostToDevice) ); in __alloc_gpu should fix this issue.

By the way, several cudaFree and free should be added to address device & host memory leaks.

Refer to master...turtleizzy:DA_STAR:master . Several api-breaking features have been added in my fork making it difficult to submit a PR directly from my fork.

@lkoshale lkoshale added the bug Something isn't working label Nov 29, 2023
@lkoshale
Copy link
Owner

Hi @turtleizzy, thank you! for going through the code and finding and fixing the bugs.
Can you create a separate branch with your changes and then create pull request to the master?

PS: I have sent you the invitation to access to the repository.

@lkoshale lkoshale added enhancement New feature or request bug Something isn't working and removed bug Something isn't working labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants