Fixed issue where Hero misplaces original delegates #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate or UITabBarControllerDelegate when enabled and disabled
|
Nice! |
lkzhao
reviewed
Jan 18, 2017
| @@ -117,6 +117,46 @@ internal extension NSObject{ | |||
| } | |||
|
|
|||
| public extension UIViewController{ | |||
| private struct PreviousDelegates { | |||
| static var navigationDelegate: UINavigationControllerDelegate? = nil | |||
There was a problem hiding this comment.
I merged too fast. Now I realized that this won't work. These two properties should be strings represent unique keys. Can you put another PR to fix this?
There was a problem hiding this comment.
You are correct! I don't know what I was thinking. I'll post a PR for this right away.
lkzhao
pushed a commit
that referenced
this pull request
Feb 16, 2017
…ate or UITabBarControllerDelegate when enabled and disabled (#46)
lkzhao
pushed a commit
that referenced
this pull request
Feb 16, 2017
…ate or UITabBarControllerDelegate when enabled and disabled (#46)
lkzhao
pushed a commit
that referenced
this pull request
Jun 14, 2017
…ate or UITabBarControllerDelegate when enabled and disabled (#46)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Hero is enabled, it sets itself as UINavigationControllerDelegate or UITabBarControllerDelegate. When Hero is disabled, it sets this delegate to nil. If there was a pre-existing delegate, it is now lost.