Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Download memory allocation failing #4

Closed
DrakiaXYZ opened this issue Apr 19, 2016 · 2 comments
Closed

Download memory allocation failing #4

DrakiaXYZ opened this issue Apr 19, 2016 · 2 comments

Comments

@DrakiaXYZ
Copy link
Collaborator

Been getting stuck at Downloding contents - 1 of 2 for a while. Testing with a relatively small title (~90MB). Threw in a bit of debugging code and it seems to be failing on the linearAlloc in DownloadFile (It's returning nullptr). There's no checks on the call, so it just sits there if this call fails.

Title I'm using is Pokemon Picross: 000400000017C100

@DrakiaXYZ
Copy link
Collaborator Author

Best guess on this is that the original tool this was based off of (FirmwareDownloader) probably didn't have any large files it had to grab. The tools is still trying to allocate the entire memory buffer at once for every download, which doesn't work too well for larger things. I'm looking into a fix right now.

@DrakiaXYZ
Copy link
Collaborator Author

I've opened a pull request #6 that should fix this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant