Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to control speed generation in Game of Life activity #380

Closed
llaske opened this issue Sep 28, 2019 · 4 comments
Closed

Allow to control speed generation in Game of Life activity #380

llaske opened this issue Sep 28, 2019 · 4 comments
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Sep 28, 2019

Add icons to control speed of generation in the game of life activity.
It could be for example a fast forward and fast backward button to a double and divide by 2 the current speed.

@prakashujjwal1010
Copy link
Contributor

@llaske , I would like to work upon this issue.
I am thinking to add two toolbar buttons fast backward and fast forward. and I think i should avoid storing the speed value in datastore .

@llaske
Copy link
Owner Author

llaske commented Sep 29, 2019

Sounds good. Do not hesitate.
You're right, you don't need to store the speed value in the datastore. BTW I think you should display it when it will change.

Note that there is no need to ask permission to work on an issue. See here.

@llaske
Copy link
Owner Author

llaske commented Oct 3, 2019

Nice start. By the way I'm not a big fan to have one button only. It means that to slow the generation you should first accelerate it. It's counter intuitive.
Alternatively may be we could use a slider instead of buttons.
Something like the one used to control rate in the Speak activity.

image

It's used here: https://bitstorm.org/gameoflife/

@llaske llaske added the to be release Fixed, to be release label Oct 19, 2019
@llaske
Copy link
Owner Author

llaske commented Oct 19, 2019

Fixed in bfe50cb

@llaske llaske added this to the v1.3 milestone Mar 11, 2020
@llaske llaske closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

2 participants