Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make responsive the toolbar in Write activity #515

Closed
llaske opened this issue Dec 21, 2019 · 9 comments
Closed

Make responsive the toolbar in Write activity #515

llaske opened this issue Dec 21, 2019 · 9 comments
Labels
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Dec 21, 2019

In Sugarizer it's important that whatever could be the screen size the Stop button is always visible to be sure the user will be able to quit the activity. So responsive activities use media queries in CSS file to hide other toolbar buttons depending of the window size. See for example Paint activity behavior:

Peek 21-12-2019 11-03

The Write activity toolbar is not responsive as you could see below:

Peek 21-12-2019 11-04

@deadnamedimmer
Copy link
Contributor

Working on it!

@deadnamedimmer
Copy link
Contributor

deadnamedimmer commented Dec 21, 2019

It looks like this was already implemented, is there anything that needs to be changed with the current implementation?

The changes were made 5 months ago by @ashish0910

@llaske
Copy link
Owner Author

llaske commented Dec 21, 2019

No it's not, the Stop button disappears like in the video capture above

@deadnamedimmer
Copy link
Contributor

It only does in my instance when the bar is showing only the Write save icon on the far left and the share icon, at least in my dev instance.

Should it continue to collapse smaller than 274px across, getting rid of the save and share icons?

@llaske
Copy link
Owner Author

llaske commented Dec 21, 2019

The problem is not related to the activity icon or to the share icon, the problem is that the Stop button should be visible. As you could see in the screen capture below, the Stop icon is not visible

image

@deadnamedimmer
Copy link
Contributor

We have different versions of Sugarizer running then, because this is what I see...

Resizing GIF

@llaske
Copy link
Owner Author

llaske commented Dec 22, 2019

Interesting the issue comes probably from #497 or #505 because it's present in the dev branch.

By the way, it's better if you've got the latest version of the dev branch to be able to reproduce and fix an issue.

@deadnamedimmer
Copy link
Contributor

Ahhh, sorry, I didn't realize I had become out of date. Thank you!

This was referenced Dec 23, 2019
@llaske
Copy link
Owner Author

llaske commented Dec 23, 2019

Fixed in #528

@llaske llaske added the to be release Fixed, to be release label Dec 23, 2019
@llaske llaske added this to the v1.3 milestone Mar 11, 2020
@llaske llaske closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants