-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a popup when image is exported in Moon activity #867
Comments
@llaske I'd like to work on this issue can you give me a headstart? |
Look on the source code I've pointed and do the tutorial on localization it should give you a good introduction. Do not hesitate to ask if you've got more specific questions. |
Can you please help me out here a bit? What mistake have I done and where should I improve upon? |
|
I will rectify the mistakes and covey the new changes and yes will go through tutorials again 🙏 thanks for guiding 😊 |
@llaske I did as you advised me to, I have added the changes in .ini file and also included the js and html files I also have made one separate modal button project, that is just a simple popup on button click project. However here I am struggling a bit; please guide me, I am new to this ps:- adding the zip file of the separate project that serves the same functionality |
You should not just add |
Thanks for guiding @llaske made changes |
Fixed in #882 |
Moon activity allow generation of the current image of the Moon in the Journal by clicking on the dedicated icon in the toolbar (to the right on the screen capture below).
It will be nice to notify the user when this export is done.
The idea is to add a popup like in the QRCode activity.
The popup should be displayed using
humane
library and the message should be localized. See here the implementation in QRCode activity.The text was updated successfully, but these errors were encountered: