Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a popup when image is exported in Moon activity #867

Closed
llaske opened this issue Oct 3, 2020 · 9 comments
Closed

Add a popup when image is exported in Moon activity #867

llaske opened this issue Oct 3, 2020 · 9 comments
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Oct 3, 2020

Moon activity allow generation of the current image of the Moon in the Journal by clicking on the dedicated icon in the toolbar (to the right on the screen capture below).

image

It will be nice to notify the user when this export is done.
The idea is to add a popup like in the QRCode activity.

image

The popup should be displayed using humane library and the message should be localized. See here the implementation in QRCode activity.

@ricknjacky
Copy link
Contributor

@llaske I'd like to work on this issue can you give me a headstart?

@llaske
Copy link
Owner Author

llaske commented Oct 3, 2020

Look on the source code I've pointed and do the tutorial on localization it should give you a good introduction. Do not hesitate to ask if you've got more specific questions.

@ricknjacky
Copy link
Contributor

ricknjacky commented Oct 3, 2020

Screenshot (164)
@llaske
I did as you advised me to. I now have an understanding of Localization and I refereed to the QR Code example, for some reason, When I run the activity(MoonActivity) now I am not getting the usual output we get, It's just a blank screen

Can you please help me out here a bit? What mistake have I done and where should I improve upon?

@llaske
Copy link
Owner Author

llaske commented Oct 3, 2020

humane library is not included in the activity, you should include the js file and the css file.
Plus you should reference it in the define section like explained in the tutorial here.
Then you will have to create a new string for the message in the .ini file.
I suggest you to complete the whole tutorial, it will help you a lot.

@ricknjacky
Copy link
Contributor

I will rectify the mistakes and covey the new changes and yes will go through tutorials again 🙏 thanks for guiding 😊

@ricknjacky
Copy link
Contributor

ricknjacky commented Oct 4, 2020

Screenshot (166)

@llaske I did as you advised me to, I have added the changes in .ini file and also included the js and html files

I also have made one separate modal button project, that is just a simple popup on button click project. However here I am struggling a bit; please guide me, I am new to this

ps:- adding the zip file of the separate project that serves the same functionality
modal.zip

@llaske
Copy link
Owner Author

llaske commented Oct 4, 2020

You should not just add humane in the define section, you should also add a humane parameter to host it.
Compare your code to the tutorial and to the QR Code activity to see differences.

@ricknjacky
Copy link
Contributor

Thanks for guiding @llaske made changes

This was referenced Oct 6, 2020
@llaske
Copy link
Owner Author

llaske commented Oct 8, 2020

Fixed in #882

@llaske llaske added the to be release Fixed, to be release label Oct 8, 2020
@llaske llaske added this to the v1.5 milestone Apr 26, 2021
@llaske llaske closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants