Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to the docker compose file. #29

Closed
steveiliop56 opened this issue Dec 4, 2023 · 4 comments
Closed

Some improvements to the docker compose file. #29

steveiliop56 opened this issue Dec 4, 2023 · 4 comments
Assignees

Comments

@steveiliop56
Copy link
Contributor

Hello,

Awesome project! Just wanted to point some things out for a docker compose file. Here they are:

  1. It would be better to use names like: dweeb-redis and dweeb so you can focus on simple names. Something like DweebUiCache makes things complicated.
  2. I would recommend using unless-stopped on both containers because with the current setup if you stop dweeb with docker stop DweebUI it wont start unless you start it while redis will : )
  3. I saw that you are using redis as cache. Are the data of redis really needed?
  4. It would be better to force users to create the dweeb directory since some users may just create a docker-compose file inside their home directory for example.
  5. I think bind volumes would be more useful since users may need to access dweeb data.

Thats all! Again awesome project!

@lllllllillllllillll
Copy link
Owner

lllllllillllllillll commented Dec 5, 2023

@steveiliop56 Thanks!
I'll make the changes to the compose file tomorrow, or if you prefer, you could fork the dev branch and make a pull request with the updated compose file. That way I can merge the changes and you'll appear as a contributor.

  1. No, Redis isn't needed at all. I just haven't gotten around to removing it yet.

@steveiliop56
Copy link
Contributor Author

Hello!

Yeah of course I will create a pr soon!

@lllllllillllllillll lllllllillllllillll self-assigned this Dec 5, 2023
@lllllllillllllillll
Copy link
Owner

I've updated the dev branch to remove redis in v0.07

@lllllllillllllillll
Copy link
Owner

Merged into dev.
These changes will be implemented in v0.08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants