You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Awesome project! Just wanted to point some things out for a docker compose file. Here they are:
It would be better to use names like: dweeb-redis and dweeb so you can focus on simple names. Something like DweebUiCache makes things complicated.
I would recommend using unless-stopped on both containers because with the current setup if you stop dweeb with docker stop DweebUI it wont start unless you start it while redis will : )
I saw that you are using redis as cache. Are the data of redis really needed?
It would be better to force users to create the dweeb directory since some users may just create a docker-compose file inside their home directory for example.
I think bind volumes would be more useful since users may need to access dweeb data.
Thats all! Again awesome project!
The text was updated successfully, but these errors were encountered:
@steveiliop56 Thanks!
I'll make the changes to the compose file tomorrow, or if you prefer, you could fork the dev branch and make a pull request with the updated compose file. That way I can merge the changes and you'll appear as a contributor.
No, Redis isn't needed at all. I just haven't gotten around to removing it yet.
Hello,
Awesome project! Just wanted to point some things out for a docker compose file. Here they are:
dweeb-redis
anddweeb
so you can focus on simple names. Something likeDweebUiCache
makes things complicated.unless-stopped
on both containers because with the current setup if you stop dweeb withdocker stop DweebUI
it wont start unless you start it while redis will : )Thats all! Again awesome project!
The text was updated successfully, but these errors were encountered: