Mania Hold Notes Cannot be Parsed

[120-cell]

The parser for mania hold notes assumes that endTime and hitSample are separated by a comma, when they are actually separated by a colon.

The result is

ValueError: end_time should be an int, got '5973:0:0:0:0:'

[tybug]

can you share a beatmap id that reproduces this?

[120-cell]

https://osu.ppy.sh/beatmapsets/2078794#mania/4353819
As far as I can tell, any map with a hold note will cause this issue.

I'm using the AUR release, maybe that changes things, but this code looks the same as on my installation:

slider/slider/beatmap.py

Lines 977 to 991 in 040e17f

	def _parse(cls, position, time, hitsound, new_combo, combo_skip, rest):
	try:
	end_time, *rest = rest
	except ValueError:
	raise ValueError('missing end_time')
	try:
	end_time = timedelta(milliseconds=int(end_time))
	except ValueError:
	raise ValueError(f'end_time should be an int, got {end_time!r}')
	if len(rest) > 1:
	raise ValueError('extra data: {rest!r}')
	return cls(position, time, hitsound, end_time, new_combo, combo_skip,
	*rest)

[120-cell]

replacing

end_time, *rest = rest

with

end_time_hit_sample, *rest = rest
end_time, *hit_sample = end_time_hit_sample.split(':')

fixed it for me.