Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beatmap TimingPoints discrepancy #56

Open
jxu opened this issue Aug 26, 2019 · 1 comment
Open

Beatmap TimingPoints discrepancy #56

jxu opened this issue Aug 26, 2019 · 1 comment

Comments

@jxu
Copy link
Contributor

jxu commented Aug 26, 2019

Beatmap parses sample_type and sample_set but docs https://osu.ppy.sh/help/wiki/osu!_File_Formats/Osu_(file_format)#timing-points specify Sample Set and Sample Index.

slider/slider/beatmap.py

Lines 179 to 191 in 55da873

try:
sample_type = int(_get(rest, 1, '0'))
except ValueError:
raise ValueError(
f'sample_type should be an int, got {sample_type!r}',
)
try:
sample_set = int(_get(rest, 2, '0'))
except ValueError:
raise ValueError(
f'sample_set should be an int, got {sample_set!r}',
)

@jxu
Copy link
Contributor Author

jxu commented Aug 26, 2019

Also inherited isn't in the class parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant