Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update star rating #95

Open
Arlind-dev opened this issue Aug 18, 2021 · 2 comments
Open

update star rating #95

Arlind-dev opened this issue Aug 18, 2021 · 2 comments

Comments

@Arlind-dev
Copy link

the star rating is still outdated, could you update it?

@tybug
Copy link
Collaborator

tybug commented Aug 19, 2021

I’d rather not have to keep our sr and pp calc constantly up to date, so I’m thinking of using pyttanko for them instead. Our current methods would remain as a thin wrapper around pyttanko with no breaking changes from a consumer standpoint.

@llllllllll I’m curious if there’s any particular reason you chose to roll your own pp and sr calc instead of using an existing library?

@llllllllll
Copy link
Owner

The reason I wrote it myself was so that I could do it in a vectorized way, instead of throwing away all the intermediate calculations for each run, you can pass vectors of hit counts and get a vector of results, which is useful for sampling to create score distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants