Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad renders after last ControlNet update -- #255

Closed
makeoo1 opened this issue Mar 10, 2023 · 31 comments
Closed

Bad renders after last ControlNet update -- #255

makeoo1 opened this issue Mar 10, 2023 · 31 comments

Comments

@makeoo1
Copy link

makeoo1 commented Mar 10, 2023

i have been using controlnet since a while without any problem. After recently updating all i am getting is "half-renders", like if SD was not completing the steps. I tested it with all the controlnet model but the result is the same

I haven't touched anything in the models folder, just added the new models to the one i already had and always worked.

I am just guessing but I think it has to do with yaml file. Problem is that i am also not sure which yaml file could be casuing the problem, since there a few.

1111 img2img
1111 models
11111 conmtrol

Any help would be very appreciated. Thx a lot!

@wcarletsdrive
Copy link

03578501-CF7C-4CF7-8DF1-670719E580D3

I am getting horrible renders too and I did a fresh install of stable diffusion webui as a friend instructed me, only changed controlnet model cache size to 2 and added an extra controlnet slot and I have this type of quality no matter what. I even followed this tutorial exactly the same and mine looks awful.. What the hell😔 I need a solution ASAP for this extension because I need to use it😔 https://youtu.be/wDM8iDK-yng

@lllyasviel
Copy link
Owner

ok let us look into it

@wcarletsdrive
Copy link

Thank you for looking into it

@lllyasviel
Copy link
Owner

can you check your setting and see if you mistakenly checked "cfg-based controlnet"?

@wcarletsdrive
Copy link

When I reinstalled webui for the fresh install, that setting was off. The only setting checked in controlnet is use mid-control on highres pass. My other install of webui previously before the fresh install is in this picture below. Either way I get bad looking renders that don't represent the style at all. Even if I am using canny or depth mode
settings
l, it all looks horrible

@lllyasviel
Copy link
Owner

  1. uncheck the cfg-based guidance and restart your webui completely, is the problem solved?
  2. does this option checked by default when fresh install?

@wcarletsdrive
Copy link

  1. No, and I used this on the previous install of webui
  2. On the fresh install of webui, this isn't checked and I still get the same bad quality

@lllyasviel
Copy link
Owner

it seems that the "cfg-based guidance" is broken. we will further look into it

@wcarletsdrive
Copy link

Thank you so much once again 🙏

@lllyasviel
Copy link
Owner

are u willing to share the input image that you tested?

@makeoo1 makeoo1 changed the title Bad renders after last ControlNet update - (caused by YAML file?) Bad renders after last ControlNet update -- Mar 10, 2023
@makeoo1
Copy link
Author

makeoo1 commented Mar 10, 2023

here's mine

img000

@makeoo1
Copy link
Author

makeoo1 commented Mar 10, 2023

i just saw the updates of the issue.

I also followed your instruction but the problem stays

@wcarletsdrive
Copy link

wcarletsdrive commented Mar 10, 2023

First image is the input
appatnfphiaa1

Second image is for the style
33

I also tried using an image that wasn't at 512 x 512, used innerfit in controlnet too.

@lllyasviel
Copy link
Owner

it seems that the building image is a difficult case for ControlNet and the model fail to recognize it. it is not a bug.
The girl case is likely to be caused by t2i adaper, which is not a part of ControlNet. let me know if you can reproduce the problem without using t2i adaper

@wcarletsdrive
Copy link

00000-3875445158
00001-2139376770

Sadly on looks I am getting and I got the style adapter from here https://huggingface.co/TencentARC/T2I-Adapter/tree/main/models

The canny, and depth models etc are from your huggingface

@lllyasviel
Copy link
Owner

image
Can you get similar quality in webui?

@lllyasviel
Copy link
Owner

image
can you send me your screenshot with exactly same setting with me?

@lllyasviel
Copy link
Owner

For the girl image case, please let me know if the problem exist without using t2i adapter. If the problem exist with pure text prompts, we will look into it deeper.

@wcarletsdrive
Copy link

wcarletsdrive commented Mar 10, 2023

All below are with having the weight in controlnet range from 0.5-1. Also, using your models instead and no adapter. If I have the weight low like 0.15, of course I see my prompt but this defeats the point of me using your extension :( My prompts look beautiful without it, but with the extension, they look like below..

weird
00005-4028782195
00006-518631049
00008-2963964337
00009-3115818428

@lllyasviel
Copy link
Owner

lllyasviel commented Mar 10, 2023

From the result it seems that the model works as intended. If no additional bugs are reported (especially that building image), we will close this soon.
The t2i-adapter is from a 3rd team (Tencent-ARC), and the webui plugin's support for t2i-adapter is experimental - because we are not sure if that model is robust enough for a production environment.
All standard controlnets are well-tested and should be robust.

If you want to transfer the prompt contents into your wanted coarse shape, a better choice could be using the depth model and tune the parameters a bit.

Thank you for your supports as always.

@wcarletsdrive
Copy link

Well I appreciate you taking the time looking into this for us at least, thank you for trying, I really wish this would be totally different. But before you go just to make sure, I am doing everything correctly on my end?

@lllyasviel
Copy link
Owner

Besides, you are encouraged to direct your issue to Tencent-ARC
https://github.com/TencentARC/T2I-Adapter
Nevertheless, please note that they are an independent team and may not have the same way as us to interact with end users.

@lllyasviel
Copy link
Owner

I closed the bug issue in webui Mikubill/sd-webui-controlnet#555
let me know if the problem still exist with that building image and I will reopen it

@lllyasviel
Copy link
Owner

And before you report to Tencent-ARC you are encouraged to see if your problem can be reproduced by their official demo https://huggingface.co/spaces/Adapter/T2I-Adapter

@wcarletsdrive
Copy link

Thanks for that recommendation. I tried it just now and used a different input image and the issue still proceeds so there is something going on. Its weird because this is a fresh install of webui. SMH..

@lllyasviel
Copy link
Owner

image
Unfortunately, this is because that model is not robust enough. The problem even exist in their official demos.
We are not able to do anything more about this. This model belongs to Tencent-ARC

@wcarletsdrive
Copy link

Thank God it isn't just me, THAT is good news, so within the two days of people making videos about this tool, something got broken. I reached out to them, and even though this will be closed, can I still send them this thread so they have deeper info and more proof of what I am dealing with?

@lllyasviel
Copy link
Owner

lllyasviel commented Mar 10, 2023

I am going to close this issue. feel free to let me know if real addtional bugs are reported and I will reopen it.

@lllyasviel
Copy link
Owner

Thank God it isn't just me, THAT is good news, so within the two days of people making videos about this tool, something got broken. I reached out to them, and even though this will be closed, can I still send them this thread so they have deeper info and more proof of what I am dealing with?

Again, any problem caused by other projects should be directly posted to that project, like https://github.com/TencentARC/T2I-Adapter/issues

@makeoo1
Copy link
Author

makeoo1 commented Mar 10, 2023

so followed your settings and it seems like its working now for me. I will test it with more random settings and prompt and let you know how is it going
11111samesetrt

@makeoo1
Copy link
Author

makeoo1 commented Mar 10, 2023

For me everything seems fixed. Thank you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants