-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings #219
Comments
I can also contribute |
@mjspeck and @rahpandey1 - appreciate this feedback. We have taken initial steps on docstrings - very simple and lightweight through the main code. Realize that there is a lot more to do here - would welcome ideas and help to improve on this starting point. On type annotations for Python, we have debated it internally quite a bit - and right now, would probably side with prioritizing docstrings as well as core documentation. |
I'm also happy to contribute on this! |
I would suggest to add docstrings systematically in the following order, where one point is one issues and hence one pull request.
|
I submitted the pull request #406 that adds docstrings to all modules, and the package. After this PR has been merged, we can move forward by adding docstrings to the classes. |
I submitted the pull request #449 to add class docstrings to four modules. I decided to split up adding class docstrings, since one pull request that adds class docstrings to all classes would be too large. |
Sorry I haven't been active on this. I'll take a look in the next week at what I can contribute. |
@mjspeck No worries. Please post first on what you are working before you start. I would recommend that you pick on module and add class docstrings to all classes there, and then submit this as a PR. Otherwise, the PR gets too big. |
Docstrings substantially complete throughout the code base. If specific request, we can open up as a new issue. |
Obviously this would be pretty big for a single issue but that fact that most methods don't seem to have docstrings is troubling. The tutorials you have are very helpful but they're not a full replacement for actual docstrings, type annotations, etc. which make it much easier to build using llmware. Happy to contribute as well, but that would require knowing what docstring format y'all prefer and other style guide standards.
The text was updated successfully, but these errors were encountered: