Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-h option not working for decompression #22

Closed
yunhua-deng opened this issue Oct 25, 2018 · 4 comments
Closed

-h option not working for decompression #22

yunhua-deng opened this issue Oct 25, 2018 · 4 comments

Comments

@yunhua-deng
Copy link

zfp -i datafile -z datafile.zfp <options> works perfectly
zfp -z datafile.zfp -o datafile.raw <options> works perfectly
zfp -i datafile -z datafile.zfp -o datafile.raw <options> works perfectly

but,
zfp -i datafile -z datafile.zfp <options> -h works
zfp -z datafile.zfp -o datafile.raw -h doesn't work and reports array size must be nonzero

What is the correct way to use -h option in order to avoid typing <options> in decompression?

PS: datafile is around several MB in byte size

@lindstro
Copy link
Member

I confirm that header support is broken in zfp 0.5.4. In this version, we added a test to ensure that any user-specified array dimensions are nonzero for compression, which is incorrectly triggered when decompressing using a header. We will push a fix in the next 24 hours.

@lindstro
Copy link
Member

@yunhua-deng, I have pushed a fix on the develop branch. Can you please verify that it addresses your issue?

@yunhua-deng
Copy link
Author

After applying the fix, zfp -i datafile -z datafile.zfp <options> -h & zfp -z datafile.zfp -o datafile.raw -h works perfectly! Please feel free to close the issue once the fix is in the master.

@lindstro
Copy link
Member

lindstro commented May 7, 2019

This fix has been added to zfp 0.5.5 and has been pushed to master. I am closing the issue.

@lindstro lindstro closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants