Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crate doesn't compile without json feature #53

Open
mbartlett21 opened this issue Dec 7, 2020 · 1 comment
Open

Crate doesn't compile without json feature #53

mbartlett21 opened this issue Dec 7, 2020 · 1 comment

Comments

@mbartlett21
Copy link

The crate's code uses extern crate serde_derive without #[cfg(feature = "json")], meaning that it doesn't compile if the json feature is disabled.

@llogiq
Copy link
Owner

llogiq commented Dec 13, 2020

I have started working on this (see #55), but there's a strange problem with the threads test. It works with the feature enabled, but not without it, and I haven't found the time to debug this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants