Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HList! vs Hlist! #132

Closed
ExpHP opened this issue Oct 4, 2018 · 5 comments · Fixed by #179
Closed

HList! vs Hlist! #132

ExpHP opened this issue Oct 4, 2018 · 5 comments · Fixed by #179
Milestone

Comments

@ExpHP
Copy link
Collaborator

ExpHP commented Oct 4, 2018

Since we're talking breaking changes, I'd like to throw this out there:

I mistype Hlist! as HList! almost every time I use it. Why is it named this way, and how do others feel about this?

@Centril
Copy link
Collaborator

Centril commented Oct 4, 2018

According to the Rust API Guidelines on naming I think Hlist! is right.

@ExpHP
Copy link
Collaborator Author

ExpHP commented Oct 4, 2018

It's like our HList trait, which is named like BTreeMap

@Centril
Copy link
Collaborator

Centril commented Oct 4, 2018

Yeah true; according to the API guidelines BTree should be Btree; this might have been before the API guidelines time?

@ExpHP
Copy link
Collaborator Author

ExpHP commented Oct 4, 2018

I consider the B to be a separate word. Notice that somebody else found it necessary to use b_tree_map as an antiexample in the guidelines, presumably because they perceive it as a separate word too

@lloydmeta
Copy link
Owner

To be honest I often get it wrong myself when using the type macro so I'm open to re-naming it. Asides from naming convention, I think I may have wanted to avoid ambiguity between the type macro and the HList trait

pub trait HList: Sized {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants