Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Move rtl.module outputs to be "result like" #93

Closed
lattner opened this issue Sep 20, 2020 · 0 comments · Fixed by #169
Closed

[RTL] Move rtl.module outputs to be "result like" #93

lattner opened this issue Sep 20, 2020 · 0 comments · Fixed by #169
Assignees
Labels
enhancement New feature or request HW Involving the `hw` dialect
Milestone

Comments

@lattner
Copy link
Collaborator

lattner commented Sep 20, 2020

Currently outputs to rtl.module are represented as function/bb arguments that are connected to. We should move to a mode where they are more "result like". For example, instead of:

 rtl.module @C(%a: i1 {rtl.direction = "in"},
                %b: i1 {rtl.direction = "out"}) {
    %0 = rtl.shl %a, %a : i1
    rtl.connect %b, %0 : i1
  }

we should have something like:

 rtl.module @C(%a: i1 {rtl.direction = "in"}) -> "b": i1 {
    %0 = rtl.shl %a, %a : i1
    return %0 : i1
  }

Given this, we can drop the rtl.direction attribute, changing it to something like an rtl.inout nullary attribute to represent the inout case.

@teqdruid teqdruid self-assigned this Oct 16, 2020
@darthscsi darthscsi added enhancement New feature or request HW Involving the `hw` dialect labels Apr 7, 2021
@darthscsi darthscsi added this to the SiFive-1 milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HW Involving the `hw` dialect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants