Skip to content

Commit

Permalink
[APFloat] Remove workaround for old clang.
Browse files Browse the repository at this point in the history
The comment says this is for clang 3.3. Our build requirements
are clang 5.0 or newer so I think we can remove this.

Reviewed By: nikic, RKSimon

Differential Revision: https://reviews.llvm.org/D140613
  • Loading branch information
topperc committed Dec 23, 2022
1 parent aad7259 commit 462a31f
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions llvm/include/llvm/ADT/APFloat.h
Original file line number Diff line number Diff line change
Expand Up @@ -859,13 +859,6 @@ class APFloat : public APFloatBase {
APFLOAT_DISPATCH_ON_SEMANTICS(makeSmallestNormalized(Neg));
}

// FIXME: This is due to clang 3.3 (or older version) always checks for the
// default constructor in an array aggregate initialization, even if no
// elements in the array is default initialized.
APFloat() : U(IEEEdouble()) {
llvm_unreachable("This is a workaround for old clang.");
}

explicit APFloat(IEEEFloat F, const fltSemantics &S) : U(std::move(F), S) {}
explicit APFloat(DoubleAPFloat F, const fltSemantics &S)
: U(std::move(F), S) {}
Expand Down

0 comments on commit 462a31f

Please sign in to comment.