Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dangling references after r274385 "[Temporary, Lifetime] Add lifetime marks for temporaries"? #28977

Closed
zmodem opened this issue Jul 18, 2016 · 3 comments
Closed

Dangling references after r274385 "[Temporary, Lifetime] Add lifetime marks for temporaries"? #28977

zmodem opened this issue Jul 18, 2016 · 3 comments
Labels
bugzilla Issues migrated from bugzilla invalid Resolved as invalid, i.e. not a bug

Comments

@zmodem
Copy link
Collaborator

zmodem commented Jul 18, 2016

Bugzilla Link 28603
Resolution INVALID
Resolved on Sep 06, 2016 01:30
Version trunk
OS Linux
Blocks #28974
CC @dlj-NaN,@wjristow

Extended Description

dlj mentioned he was seeing failures due to dangling references after r274385, and that they went away if Tim disables his change.

Is there a bug somewhere tracking this? Should we be rolling back the change (possibly just on the 3.9 branch if it's considered risky)?
@dlj-NaN
Copy link
Contributor

dlj-NaN commented Jul 18, 2016

All the failures we observed were user code, not LLVM bugs (i.e., the change exposed code which was already broken).

@zmodem
Copy link
Collaborator Author

zmodem commented Jul 18, 2016

Oh, I see. Thanks for clarifying.

@wjristow
Copy link
Collaborator

wjristow commented Sep 6, 2016

See bug 30290 for a test-case that gets a run-time failure beginning with
r274385. But as described there, it looks suspiciously like that failure is
just a much older bug that now is more likely to happen with the change of
r274385. Cross-referencing here, in case that happens to actually be a bug
in r274385.

@zmodem zmodem mentioned this issue Jul 18, 2016
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla invalid Resolved as invalid, i.e. not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zmodem @dlj-NaN @wjristow