Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an arity threshhold for binpacking arguments #31255

Open
zetafunction mannequin opened this issue Feb 9, 2017 · 0 comments
Open

Add an arity threshhold for binpacking arguments #31255

zetafunction mannequin opened this issue Feb 9, 2017 · 0 comments
Labels
bugzilla Issues migrated from bugzilla clang-format

Comments

@zetafunction
Copy link
Mannequin

zetafunction mannequin commented Feb 9, 2017

Bugzilla Link 31907
Version unspecified
OS Windows NT

Extended Description

When a function has a lot of arguments, binpacking can makes things less readable. It would be nice if there was an arity threshhold; if you exceed it, then every argument is on its own line rather than being bin packed.

Here's the code before formatting:

kern_return_t result =
mach_vm_region(mach_task_self(),
reprotection_start,
reprotection_length,
VM_REGION_BASIC_INFO_64,
reinterpret_cast<vm_region_info_t>(&info),
&count,
&unused);

Here's the code after formatting:

kern_return_t result = mach_vm_region(
mach_task_self(), reprotection_start, reprotection_length,
VM_REGION_BASIC_INFO_64, reinterpret_cast<vm_region_info_t>(&info),
&count, &unused);

Here's how it ought to look:

kern_return_t result =
mach_vm_region(mach_task_self(),
reprotection_start,
reprotection_length,
VM_REGION_BASIC_INFO_64,
reinterpret_cast<vm_region_info_t>(&info),
&count,
&unused);

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clang-format
Projects
None yet
Development

No branches or pull requests

0 participants