lib/Transforms/InstCombine/InstructionCombining.cpp broken -- cannot link.

[llvmbot]

Bugzilla Link	35947
Resolution	FIXED
Resolved on	Apr 06, 2018 20:59
Version	6.0
OS	Windows NT
Blocks	#35997
Reporter	LLVM Bugzilla Contributor
CC	@bostick,@EugeneZelenko
Fixed by commit(s)	r326843 r329480

Extended Description

Fix by EugeneZelenko on Oct 24 2017 broke the linking of LLVM-C applications on Windows. LLVMInitializeInstCombine is declared extern "C" in the LLVM-C header Initialization.h, but not declared extern "C" surrounding the definition for the function in lib/Transforms/InstCombine/InstructionCombining.cpp. The inconsistency can cause a link fail. It's in release_60 and master. Could someone please fix this? One solution that works is to re-add the removed #include "llvm-c/Initialization.h"

[llvmbot]

assigned to @bostick

[EugeneZelenko]

I delivered Brenton Bostick;s fix in trunk in r326843.

It may be too late for 6.0, but should be backported to 6.0.1.

[tstellar]

Merged: r329480

[zmodem]

mentioned in issue #35997