Merge r324747 into the 6.0 branch : Reapply "AMDGPU: Add 32-bit constant address space"

[llvmbot]

Bugzilla Link	36351
Resolution	WONTFIX
Resolved on	Feb 26, 2018 02:09
Version	6.0
OS	All
Blocks	#35152
Reporter	LLVM Bugzilla Contributor
CC	@zmodem,@arsenm
Fixed by commit(s)	r324747

Extended Description

Is it OK to merge the following revision(s) to the 6.0 branch?

[llvmbot]

https://reviews.llvm.org/rL324747

[llvmbot]

Prerequisite:
llvm/llvm-bugzilla-archive#36350

Clang fix that should be applied at the same time:
llvm/llvm-bugzilla-archive#36352

[llvmbot]

This is a feature for AMDGPU that we would like to have in LLVM 6.0.

[zmodem]

+Matt to call it.

I'm not keen on adding new functionality this late in the release process.

[zmodem]

Matt: ping?

[zmodem]

*** Bug llvm/llvm-bugzilla-archive#36352 has been marked as a duplicate of this bug. ***

[zmodem]

From 36352, also merge r324747 if we merge this.

[zmodem]

Matt: ping?

Time for 6.0.0 is running out fast.

[arsenm]

Matt: ping?

Time for 6.0.0 is running out fast.

I think there should be a note about the support being experimental for addrspace 6, but I don’t think this should break anything else

[zmodem]

Matt: ping?

Time for 6.0.0 is running out fast.

I think there should be a note about the support being experimental for
addrspace 6, but I don’t think this should break anything else

So you're saying we should merge this?

Can you please prepare patches that apply cleanly and pass tests on the branch?

I tried merging r324747+r324748 locally but get lots of clang test failures:

Failing Tests (18):
Clang :: CodeGen/address-space.c
Clang :: CodeGen/default-address-space.c
Clang :: CodeGenCXX/amdgcn-automatic-variable.cpp
Clang :: CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp
Clang :: CodeGenCXX/vla.cpp
Clang :: CodeGenOpenCL/addr-space-struct-arg.cl
Clang :: CodeGenOpenCL/address-space-constant-initializers.cl
Clang :: CodeGenOpenCL/address-spaces.cl
Clang :: CodeGenOpenCL/amdgcn-automatic-variable.cl
Clang :: CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
Clang :: CodeGenOpenCL/amdgpu-env-amdgiz.cl
Clang :: CodeGenOpenCL/amdgpu-sizeof-alignof.cl
Clang :: CodeGenOpenCL/atomic-ops.cl
Clang :: CodeGenOpenCL/byval.cl
Clang :: CodeGenOpenCL/func-call-dbg-loc.cl
Clang :: CodeGenOpenCL/lifetime.cl
Clang :: CodeGenOpenCL/vla.cl
Clang :: Index/pipe-size.cl

[llvmbot]

Hans, I've changed my mind. Let's drop this and close/reject this request.

[zmodem]

mentioned in issue llvm/llvm-bugzilla-archive#36352