Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge r324748 into the 6.0 branch : AMDGPU: Update for datalayout change #35700

Closed
llvmbot opened this issue Feb 12, 2018 · 4 comments
Closed
Labels
bugzilla Issues migrated from bugzilla duplicate Resolved as duplicate

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 12, 2018

Bugzilla Link 36352
Resolution DUPLICATE
Resolved on Feb 19, 2018 07:48
Version 6.0
OS All
Blocks #35152
Reporter LLVM Bugzilla Contributor
CC @zmodem,@arsenm
Fixed by commit(s) r324748

Extended Description

Is it OK to merge the following revision(s) to the 6.0 branch?

@llvmbot
Copy link
Collaborator Author

llvmbot commented Feb 12, 2018

@zmodem
Copy link
Collaborator

zmodem commented Feb 13, 2018

I don't have context. What datalayout change, and why does it need to be merged?

+Matt

@llvmbot
Copy link
Collaborator Author

llvmbot commented Feb 14, 2018

The commit should be applied together with:
[Bug 36351] Merge r324747 into the 6.0 branch : Reapply "AMDGPU: Add 32-bit constant address space"

That is, if one of them is merged, both of them should be merged. Otherwise, there will be lit tests failures.

@zmodem
Copy link
Collaborator

zmodem commented Feb 19, 2018

Okay, let's just use one bug to track it.

*** This bug has been marked as a duplicate of bug llvm/llvm-bugzilla-archive#36351 ***

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla duplicate Resolved as duplicate
Projects
None yet
Development

No branches or pull requests

2 participants