Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge r326404 into the 6.0 branch : [IPSCCP] do not break musttail invariant (#36485 ) #35952

Closed
llvmbot opened this issue Mar 5, 2018 · 7 comments
Labels
bugzilla Issues migrated from bugzilla

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 5, 2018

Bugzilla Link 36604
Resolution FIXED
Resolved on Apr 11, 2018 15:40
Version 6.0
OS All
Blocks #35997
Reporter LLVM Bugzilla Contributor
CC @fhahn,@tstellar
Fixed by commit(s) r326404 r329855

Extended Description

Is it OK to merge the following revision(s) to the 6.0 branch?

@llvmbot
Copy link
Collaborator Author

llvmbot commented Mar 5, 2018

@tstellar
Copy link
Collaborator

tstellar commented Apr 7, 2018

Hi Eli,

Is this OK to merge to the release_60 branch?

@efriedma-quic
Copy link
Collaborator

Yes, should be fine to merge.

@tstellar
Copy link
Collaborator

Fedor can you merge this or paste a working patch to this email. When I merge this to release_60 and fix a small compile error, the Transforms/IPConstantProp/musttail-call.ll test case fails for me.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Apr 10, 2018

Suggested patch
Here's a suggested patch. Apparently, the optimizer doesn't remove the calls themselves in 6.0, so the original test can be ported only partially. Please let me know if you agree with my assessment of it.

Thanks!

@tstellar
Copy link
Collaborator

Merged: r329855

@zmodem
Copy link
Collaborator

zmodem commented Nov 27, 2021

mentioned in issue #35997

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

4 participants