Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge r325653, r325651, r325657, r325713 into the 6.0.1 release #36012

Closed
llvmbot opened this issue Mar 9, 2018 · 7 comments
Closed

Merge r325653, r325651, r325657, r325713 into the 6.0.1 release #36012

llvmbot opened this issue Mar 9, 2018 · 7 comments
Labels
bugzilla Issues migrated from bugzilla

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 9, 2018

Bugzilla Link 36664
Resolution FIXED
Resolved on Apr 11, 2018 06:06
Version 6.0
OS All
Blocks #35997
Reporter LLVM Bugzilla Contributor
CC @tstellar
Fixed by commit(s) r329798 r329799 r329800

Extended Description

All three patches are for spectre variant two mitigation, and are titled "[mips] Spectre variant two mitigation for MIPSR2". The last addresses' a post commit review.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Mar 9, 2018

The LLVM part needs a patch on top of it.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Mar 9, 2018

Patch for test failures when applying the Spectre patch.
The LLVM patch requires this to pass the LLVM test-suite.

@tstellar
Copy link
Collaborator

tstellar commented Apr 7, 2018

Did you mean to include r325657 or was that a typo?

@llvmbot
Copy link
Collaborator Author

llvmbot commented Apr 7, 2018

Yes, r325657 was a typo. It should have been: r325657.

(https://reviews.llvm.org/rL325647) [mips][lld] Spectre variant two mitigation for MIPSR2

Thanks for catching this.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Apr 7, 2018

Yes, r325657 was a typo. It should have been: r325657.

(https://reviews.llvm.org/rL325647) [mips][lld] Spectre variant two
mitigation for MIPSR2

Thanks for catching this.

Yes, I made the typo again. r325647 instead of r325657. The link and patch title point to the correct patch.

@tstellar
Copy link
Collaborator

tstellar commented Apr 9, 2018

These all look fine, go ahead and merge.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Apr 11, 2018

All patches merged. I've squashed the patch attached to this report into the LLVM patch, and the post commit change for LLD into the LLD patch.

Thanks,
Simon

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

2 participants