Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge r330345 into the 6.0 branch : [if-converter] Handle BBs that terminate in ret during diamond conversion #36729

Closed
vchuravy opened this issue May 8, 2018 · 6 comments
Closed

Merge r330345 into the 6.0 branch : [if-converter] Handle BBs that terminate in ret during diamond conversion #36729

vchuravy opened this issue May 8, 2018 · 6 comments
Assignees
@kparzysz-quic
Labels
bugzilla Issues migrated from bugzilla

Comments

@vchuravy
Copy link
Contributor

vchuravy commented May 8, 2018

Bugzilla Link 37381
Resolution FIXED
Resolved on May 30, 2018 09:51
Version 6.0
OS All
Blocks #35997
CC @tstellar
Fixed by commit(s) r330345 r333561

Extended Description

Is it OK to merge the following revision(s) to the 6.0 branch?
@vchuravy
Copy link
Contributor Author

vchuravy commented May 8, 2018

assigned to @kparzysz-quic

@vchuravy
Copy link
Contributor Author

vchuravy commented May 8, 2018

https://reviews.llvm.org/rL330345

@tstellar
Copy link
Collaborator

tstellar commented May 8, 2018

Hi David,

Is this OK to merge?

@tstellar
Copy link
Collaborator

Hi David,

Is this OK to merge?

I was confused by the differential link in the commit. This is not actually an InstCombiner patch.

Krzysztof you are the patch author, is this safe to merge?

@kparzysz-quic
Copy link

Yes, it's ok to merge.

@tstellar
Copy link
Collaborator

Merged: r333561

@zmodem zmodem mentioned this issue Mar 8, 2018
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kparzysz-quic kparzysz-quic

Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstellar @vchuravy @kparzysz-quic