Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge r330926 and r330927 into the 6.0.1 release (ConfigFiles) #36792

Closed
spavloff opened this issue May 14, 2018 · 4 comments
Closed

Merge r330926 and r330927 into the 6.0.1 release (ConfigFiles) #36792

spavloff opened this issue May 14, 2018 · 4 comments
Assignees
@tstellar
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'

Comments

@spavloff
Copy link
Collaborator

Bugzilla Link 37444
Resolution FIXED
Resolved on May 17, 2018 12:04
Version 6.0
OS All
Blocks #35997
CC @tstellar
Fixed by commit(s) r330926 r330927 r332649 r332650

Extended Description

Is it OK to merge the following revision(s) to the 6.0 branch?

330926: [ConfigFiles] Update argument strings when merging argrument lists
330927: Make test more platform neutral

They fix an issue that can prevent from using config files in some cases. The change is confined to config file support only and cannot affect other functionality.
@spavloff
Copy link
Collaborator Author

assigned to @tstellar

@tstellar
Copy link
Collaborator

Hi Richard,

Are these OK to merge?

http://reviews.llvm.org/rL330926
http://reviews.llvm.org/rL330927

@zygoloid
Copy link
Mannequin

zygoloid mannequin commented May 17, 2018

These look fine to merge.

@tstellar
Copy link
Collaborator

Merged: r332649 r332650

@zmodem zmodem mentioned this issue Mar 8, 2018
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstellar tstellar

Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tstellar @spavloff