Merge rL332302, rL332680, rL332682, rL332694 into 6.0.1

[Keno]

Bugzilla Link	37525
Resolution	FIXED
Resolved on	Jun 11, 2018 16:24
Version	6.0
OS	All
Blocks	#35997
CC	@topperc,@arsenm,@tstellar,@vchuravy
Fixed by commit(s)	r332680 r332682 r332694 r333469 r333470 r333477

Extended Description

Please merge the following revisions into 6.0.1. They fix crashing bugs in
the julia test suite after the upgrade to LLVM 6.0:

rL332302 [InstCombine] fix crash due to ignored addrspacecast (Reviewer: arsenm)
rL332680 [X86DomainReassignment] Don't delete IMPLICIT_DEF nodes (Reviewer: craig.topper)
rL332682 [X86DomainReassignment] Don't compare stack-allocated values by address (Reviewer: craig.topper)
rL332694 [X86DomainReassignment] Hopefully fix buildbot failure (no reviewer, but just a typo fix in the test case for the previous one - can be squashed into that for the cherry-pick)

[Keno]

assigned to @majnemer

[tstellar]

Hi Craig,

Are these X86 patches OK to merge?

http://reviews.llvm.org/rL332680
http://reviews.llvm.org/rL332682
http://reviews.llvm.org/rL332694

[topperc]

Yes, they are ok to merge. Thanks!

[tstellar]

Hi Craig,

Are these X86 patches OK to merge?

http://reviews.llvm.org/rL332680
http://reviews.llvm.org/rL332682
http://reviews.llvm.org/rL332694

Keno, I tried merging these patches, but the domain-reassignment-test.ll fails, can you try merging these?

[Keno]

Valentin Churavy has a version of these patches that he rebased against 6.0 and we're using for Julia:

https://github.com/staticfloat/LLVMBuilder/blob/master/patches/llvm_patches/0014-llvm-rL332680.patch
https://github.com/staticfloat/LLVMBuilder/blob/master/patches/llvm_patches/0015-llvm-rL332682.patch
https://github.com/staticfloat/LLVMBuilder/blob/master/patches/llvm_patches/0016-llvm-rL332302.patch
https://github.com/staticfloat/LLVMBuilder/blob/master/patches/llvm_patches/0017-llvm-rL332694.patch

Maybe try those. I can also try doing it, but I'm not sure how to commit to the release branch, so in that case, I may need you to provide instructions.

[topperc]

Will merging r324497 first make the other patches apply correctly? That patch regenerated the test with the update_mir_test script.

[tstellar]

Will merging r324497 first make the other patches apply correctly? That
patch regenerated the test with the update_mir_test script.

That patch was is already in the release_60 branch.

[tstellar]

I was able to fix the test. I had to add -mcpu=skylake-avx512 to the llvm-mc invocation in the domain-reassignment-test.ll test.

[tstellar]

I've merged the X86 commits as r333469 and r333470 (I squashed the last to into one commit).

[tstellar]

Hi David,

What do you think about the InstCombine patch:

https://reviews.llvm.org/rL332302

[majnemer]

Hi David,

What do you think about the InstCombine patch:

https://reviews.llvm.org/rL332302

LGTM

[tstellar]

Merged the InstCombine fix: r333477