Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to revert 23058f9dd4d7e18239fd63b6da52549514b45fda to fix Cuda #43908

Closed
alexey-bataev opened this issue Jan 16, 2020 · 3 comments
Closed
Labels
bugzilla Issues migrated from bugzilla openmp

Comments

@alexey-bataev
Copy link
Member

Bugzilla Link 44563
Resolution FIXED
Resolved on Jan 17, 2020 01:34
Version unspecified
OS All
Blocks #43900
CC @dwblaikie,@zmodem

Extended Description

Commit 23058f9 needs to be reverted to fix Cuda with RTTI support.

@dwblaikie
Copy link
Collaborator

Bugs might not be the best way to communicate the need for a revert - replying to the original commit (& cc'ing any relevant parties - the author, code owners, reviewrs, etc) and/or review thread might get you more traction.

@alexey-bataev
Copy link
Member Author

Bugs might not be the best way to communicate the need for a revert -
replying to the original commit (& cc'ing any relevant parties - the author,
code owners, reviewrs, etc) and/or review thread might get you more traction.

It is reverteв in trunk already, need to revert in 10 branch too.

@zmodem
Copy link
Collaborator

zmodem commented Jan 17, 2020

The revert (6b29aa2) has been cherry-picked to 10.x in 572c7f6. Thanks!

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla openmp
Projects
None yet
Development

No branches or pull requests

3 participants