[llvm-ml] Unused function causing warnings with gcc 10.1.1

[ericastor]

Bugzilla Link	46763
Resolution	FIXED
Resolved on	Jul 20, 2020 06:53
Version	11.0
OS	All
Blocks	#46070
CC	@dwblaikie,@ericastor,@zmodem,@slacka
Fixed by commit(s)	47a3b85

Extended Description

Email from Luke Benes:

After bc8e262afe83
[ms] [llvm-ml] Add initial MASM STRUCT/UNION support

With gcc 10.1, I'm seeing:

[ 21%] Building CXX object lib/MC/MCParser/CMakeFiles/LLVMMCParser.dir/MasmParser.cpp.o
/llvm/lib/MC/MCParser/MasmParser.cpp:3836:6: warning: ‘bool {anonymous}::MasmParser::emitStructValue(const {anonymous}::StructInfo&)’ defined but not used [-Wunused-function]
3836 | bool MasmParser::emitStructValue(const StructInfo &Structure) {
| ^~~~~~~~~~

Could you please take a look at it and backport any fix to 11.x?

This is in fact an unused function, and we should eliminate the warning.

[ericastor]

To fix this in the 11.0 release, we should just need to merge commit:
47a3b85

[dwblaikie]

FWIW, you really don't have to file bugs for things like this (& probably best not to - adds noise to the bug database/people triaging bugs/etc) - commits don't require bugs to justify them & can be explained directly in the commit message.

[ericastor]

This was not filed to explain the commit, but to mark this as release-blocking due to Luke's request.

[dwblaikie]

This was not filed to explain the commit, but to mark this as
release-blocking due to Luke's request.

Oh, thanks - good to understand!

[zmodem]

To fix this in the 11.0 release, we should just need to merge commit:
47a3b85

Pushed to 11.x as c467be7. Thanks!