Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick ecea7218fb9b994b26471e9877851cdb51a5f1d4 and cdef5a7161767c2c4b3b7cb2542cf1d29b6d4a09 #48587

Closed
kadircet opened this issue Feb 18, 2021 · 4 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla clangd

Comments

@kadircet
Copy link
Member

Bugzilla Link 49243
Resolution FIXED
Resolved on Feb 22, 2021 12:26
Version unspecified
OS All
Blocks #48246
CC @sam-mccall,@tstellar
Fixed by commit(s) ecea721 cdef5a7 d840463 b601100

Extended Description

These two make our config system more useful to windows users. We were handling paths case-sensitively which isn't true for windows and apple.

ecea721
cdef5a7

@kadircet
Copy link
Member Author

assigned to @sam-mccall

@tstellar
Copy link
Collaborator

Sam, what do you think about backporting these?

Kadir, these don't apply to the release/12.x branch, can you resolve the conflicts and push a branch up to a GitHub repo?

@sam-mccall
Copy link
Collaborator

They don't apply cleanly because we're missing an important dependency b63cd4d

I'd considered asking for that one to be cherrypicked in its own right but didn't think it was critical enough. I believe they're safe enough though, and significant problems for windows users, so we picking all three seems reasonable to me.

Together the three apply cleanly, but I've prepared a branch anyway:

release/12.x...sam-mccall:clangd-path-case-12-cherrypicks

@tstellar
Copy link
Collaborator

Merged: b601100

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clangd
Projects
None yet
Development

No branches or pull requests

3 participants