Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpuid.h has incorrect value for bit_AVXVNNI #53392

Closed
wch0x01 opened this issue Jan 24, 2022 · 4 comments
Closed

cpuid.h has incorrect value for bit_AVXVNNI #53392

wch0x01 opened this issue Jan 24, 2022 · 4 comments
Labels
backend:X86 confirmed Verified by a second party

Comments

@wch0x01
Copy link

wch0x01 commented Jan 24, 2022

Apologies if this has been addressed already.

In /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/cpuid.h
Leaf 7, subleaf 1, register EAX
#define bit_AVXVNNI 0x00000008

It should be
#define bit_AVXVNNI 0x00000010

According to
Intel 64 and IA-32 Architectures Software Developer's Manual
Volume 2 (2A, 2B, 2C, & 2D): Instruction SetReference, A-Z
325383-076US, December 2021
https://www.intel.com/content/www/us/en/developer/articles/technical/intel-sdm.html

There are other bits in leaf 7 that should probably be defined for newer CPUs.

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 24, 2022

@llvm/issue-subscribers-backend-x86

@RKSimon
Copy link
Collaborator

RKSimon commented Jan 28, 2022

This was fixed in trunk at f6984b2

@phoebewang @topperc @tstellar Is it too late to get this into 13.x do you think? The report was from a xcode toolchain so who knows if it'd even reach there tbh......

@phoebewang
Copy link
Contributor

I support it if it's in time.

@RKSimon RKSimon added the confirmed Verified by a second party label Jan 30, 2022
@RKSimon
Copy link
Collaborator

RKSimon commented Feb 6, 2022

Tentatively closing this - its unlikely we'll see another 13.x general release now that 14.x development has started

@RKSimon RKSimon closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:X86 confirmed Verified by a second party
Projects
None yet
Development

No branches or pull requests

5 participants