Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Add cmake to source release tarballs" to 14.x #54183

Closed
mati865 opened this issue Mar 3, 2022 · 7 comments
Closed

Backport "Add cmake to source release tarballs" to 14.x #54183

mati865 opened this issue Mar 3, 2022 · 7 comments

Comments

@mati865
Copy link
Contributor

mati865 commented Mar 3, 2022

Could 32a0482 be backported to 14.x ?
I think it's rather critical because without it trying to build various LLVM projects from tarballs fails with errors like:

CMake Error at D:/Projekty/msys2/MINGW-packages/mingw-w64-clang/src/compiler-rt/CMakeLists.txt:31 (include):
  include could not find requested file:

    SetPlatformToolchainTools


CMake Error at D:/Projekty/msys2/MINGW-packages/mingw-w64-clang/src/compiler-rt/cmake/base-config-ix.cmake:9 (include):
  include could not find requested file:

    ExtendPath

First noticed it with LLVM 14 RC1 but seeing the fix was in the works I though it would be fixed with RC2. It's not the case though and IIUC backporting that commit should fix building from tarballs for the next RC/release.

@h-vetinari
Copy link
Contributor

It doesn't cherry-pick cleanly, but there's a backport waiting in llvmbot#110, see also #53281

@mati865
Copy link
Contributor Author

mati865 commented Mar 4, 2022

Sorry couldn't find it due to different error order. Should I close this one?

@h-vetinari
Copy link
Contributor

Backport happened (thanks!), so this can be closed. :)

@mati865
Copy link
Contributor Author

mati865 commented Mar 5, 2022

Thank you!

@mati865 mati865 closed this as completed Mar 5, 2022
@tstellar
Copy link
Collaborator

tstellar commented Mar 8, 2022

Merged: 1e3d5cc

@rubyFeedback
Copy link

rubyFeedback commented Sep 6, 2022

Just ran into this issue. Could a new minor 14.x release be made with the fix? Somehow the more recent cmake versions seemed to have issues, whereas I think I remember having compiled llvm just fine with an older cmake version.

Edit: the error was

-- Performing Test CXX_SUPPORTS_NO_NESTED_ANON_TYPES_FLAG - Failed
-- Looking for include file sys/inotify.h
-- Looking for include file sys/inotify.h - found
-- Not building amdgpu-arch: hsa-runtime64 not found
CMake Error at tools/clang/cmake/modules/CMakeLists.txt:1 (include):
  include could not find requested file:

    ExtendPath


CMake Error at tools/clang/cmake/modules/CMakeLists.txt:3 (include):
  include could not find requested file:

    FindPrefixFromConfig

CMake Error at tools/clang/cmake/modules/CMakeLists.txt:42 (find_prefix_from_config):
  Unknown CMake command "find_prefix_from_config".

@seppeon
Copy link

seppeon commented Oct 13, 2022

Just ran into this issue. Could a new minor 14.x release be made with the fix? Somehow the more recent cmake versions seemed to have issues, whereas I think I remember having compiled llvm just fine with an older cmake version.

Edit: the error was

-- Performing Test CXX_SUPPORTS_NO_NESTED_ANON_TYPES_FLAG - Failed
-- Looking for include file sys/inotify.h
-- Looking for include file sys/inotify.h - found
-- Not building amdgpu-arch: hsa-runtime64 not found
CMake Error at tools/clang/cmake/modules/CMakeLists.txt:1 (include):
  include could not find requested file:

    ExtendPath


CMake Error at tools/clang/cmake/modules/CMakeLists.txt:3 (include):
  include could not find requested file:

    FindPrefixFromConfig

CMake Error at tools/clang/cmake/modules/CMakeLists.txt:42 (find_prefix_from_config):
  Unknown CMake command "find_prefix_from_config".

We have the same issue when trying to build compiler-rt-15.0.2.src.tar.xz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants