Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flang] FIR verification failure with select #56143

Closed
kiranchandramohan opened this issue Jun 21, 2022 · 5 comments
Closed

[Flang] FIR verification failure with select #56143

kiranchandramohan opened this issue Jun 21, 2022 · 5 comments
Assignees
Labels

Comments

@kiranchandramohan
Copy link
Contributor

kiranchandramohan commented Jun 21, 2022

A verification failure is seen with select and strings.

Verification Error (Originally seen with cam4)

error: loc("./select.f90":6:8): operand #0 does not dominate this use
error: verification of lowering to FIR failed

Reproducer

module m
  character(len=16) :: x
contains
  subroutine hd
    if (.true.) then
       select case(trim(x))
       case('abc')
          continue
       end select
    end if
  end subroutine
end module m
@kiranchandramohan kiranchandramohan created this issue from a note in Flang Spec2017 issues (To Do) Jun 21, 2022
@llvmbot
Copy link
Collaborator

llvmbot commented Jun 21, 2022

@llvm/issue-subscribers-flang-ir

@PeixinQiao
Copy link
Contributor

Are these issues open to anyone to fix?

@kiranchandramohan
Copy link
Contributor Author

Yes, @PeixinQiao. Please assign it to yourself if you are working on it.

@PeixinQiao
Copy link
Contributor

Thanks @kiranchandramohan . I will take a look at this.

@PeixinQiao PeixinQiao self-assigned this Jun 22, 2022
@kiranchandramohan kiranchandramohan moved this from To Do to In Progress in Flang Spec2017 issues Jun 22, 2022
@kiranchandramohan
Copy link
Contributor Author

Fixed by https://reviews.llvm.org/D128852. Thanks @vdonaldson.

@kiranchandramohan kiranchandramohan moved this from In Progress to Done in Flang Spec2017 issues Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants