Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support %b and %B from WG14 N2630 in format string checking #56885

Closed
enh-google opened this issue Aug 2, 2022 · 1 comment
Closed

support %b and %B from WG14 N2630 in format string checking #56885

enh-google opened this issue Aug 2, 2022 · 1 comment
Assignees
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer

Comments

@enh-google
Copy link
Contributor

glibc already added %b and %B (and apparently GCC knows about this), and i'm adding them to bionic https://android-review.googlesource.com/c/platform/bionic/+/2169037, but needed to use #pragma to shut clang up for the tests.

one interesting gnarl here is that for Android whether %b/%B are allowed or not will depend on the target API level. (similar should be true for %m which went into API level 29, but no-one's ever complained that clang doesn't know that, so it probably doesn't matter?)

@EugeneZelenko EugeneZelenko added clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer and removed new issue labels Aug 2, 2022
@MaskRay MaskRay self-assigned this Aug 3, 2022
@MaskRay
Copy link
Member

MaskRay commented Aug 3, 2022

printf: https://reviews.llvm.org/D131057

scanf is not done. Fortify source is not done.

@MaskRay MaskRay closed this as completed in 88501dc Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer
Projects
None yet
Development

No branches or pull requests

3 participants