Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLSL] Validate system value semantic based on the entry profile instead of shader profile #57880

Closed
python3kgae opened this issue Sep 21, 2022 · 1 comment
Assignees
Labels
HLSL HLSL Language Support

Comments

@python3kgae
Copy link
Contributor

When report diag::err_hlsl_attr_unsupported_in_stage, the validation for system value semantic is checking shader profile.
But it is OK for a shader to have both pixel entry and compute entry at the same time.
Need to validate system value semantic based on the profile of the entry function.

@python3kgae python3kgae added the HLSL HLSL Language Support label Sep 21, 2022
@bogner bogner self-assigned this Aug 24, 2023
@bogner
Copy link
Contributor

bogner commented Aug 29, 2023

Fixed in ef2b170

@bogner bogner closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HLSL HLSL Language Support
Projects
Status: Done
Development

No branches or pull requests

2 participants