Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLSL] Need better name for ParsedAttr::AS_HLSLSemantic #57882

Closed
python3kgae opened this issue Sep 21, 2022 · 2 comments · Fixed by #89309
Closed

[HLSL] Need better name for ParsedAttr::AS_HLSLSemantic #57882

python3kgae opened this issue Sep 21, 2022 · 2 comments · Fixed by #89309
Assignees
@bob80905
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support

Comments

@python3kgae
Copy link
Contributor

python3kgae commented Sep 21, 2022 •
edited by davidcook-msft

The choice of AS_HLSLSemantic is an unfortunate name for both resources and semantics.

The proposed new name is ParsedAttr::AS_HLSLAnnotation

AC:

  • AS_HLSLSemantic enum value is renamed to AS_HLSLAnnotation
  • Source and tests are updated appropriately
  • Double check if HLSLSemantic phrasing appears in other locations like method names or SEMA that also need to be adjusted to reflect the new spelling
@python3kgae python3kgae added the HLSL HLSL Language Support label Sep 21, 2022
@bob80905 bob80905 self-assigned this Mar 28, 2024
@bob80905 bob80905 mentioned this issue Apr 23, 2024
Merged
@bob80905
Copy link
Contributor

Closed with #89309

@EugeneZelenko EugeneZelenko added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Apr 23, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 23, 2024

@llvm/issue-subscribers-clang-frontend

Author: Xiang Li (python3kgae)

The choice of AS_HLSLSemantic is an unfortunate name for both resources and semantics.

The proposed new name is ParsedAttr::AS_HLSLAnnotation

AC:

  • AS_HLSLSemantic enum value is renamed to AS_HLSLAnnotation
  • Source and tests are updated appropriately
  • Double check if HLSLSemantic phrasing appears in other locations like method names or SEMA that also need to be adjusted to reflect the new spelling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bob80905 bob80905

Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support
Projects
HLSL Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NFC] Rename hlsl semantics to hlsl annotations bob80905/llvm-project
4 participants
@EugeneZelenko @python3kgae @bob80905 @llvmbot