Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLSL] Add Resource "shape" and "ROV" to HLSLResourceAttr #57991

Closed
llvm-beanz opened this issue Sep 26, 2022 · 5 comments
Closed

[HLSL] Add Resource "shape" and "ROV" to HLSLResourceAttr #57991

llvm-beanz opened this issue Sep 26, 2022 · 5 comments
Assignees
Labels
clang:codegen HLSL HLSL Language Support

Comments

@llvm-beanz
Copy link
Collaborator

The HLSL Resource attribute currently captures the some of the possible types of resource information, but not all. The attribute should also capture the "Shape" of all resources, and have an optional bool for ROVs.

@python3kgae python3kgae self-assigned this Oct 5, 2022
@python3kgae
Copy link
Contributor

shape is done.
Need to ROV next.

@bogner bogner assigned bogner and unassigned python3kgae Oct 30, 2023
@bogner
Copy link
Contributor

bogner commented Oct 30, 2023

We'll also need "HasCounter" here. We should check if anything else needs this treatment, but I think things like counts, element type, and stride should already be visible elsewhere in the AST.

@bogner
Copy link
Contributor

bogner commented Dec 8, 2023

See #74896

@bogner
Copy link
Contributor

bogner commented Dec 9, 2023

This is done as of #74896

@llvmbot
Copy link
Collaborator

llvmbot commented Dec 10, 2023

@llvm/issue-subscribers-clang-codegen

Author: Chris B (llvm-beanz)

The HLSL Resource attribute currently captures the some of the possible types of resource information, but not all. The attribute should also capture the "Shape" of all resources, and have an optional bool for ROVs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:codegen HLSL HLSL Language Support
Projects
Status: Done
Development

No branches or pull requests

5 participants