Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport UB workaround for GCC LTO builds #62699

Closed
thesamesam opened this issue May 13, 2023 · 6 comments · Fixed by llvm/llvm-project-release-prs#445
Closed

Backport UB workaround for GCC LTO builds #62699

thesamesam opened this issue May 13, 2023 · 6 comments · Fixed by llvm/llvm-project-release-prs#445
Labels
cmake Build system in general and CMake in particular release:backport release:merged
Milestone
LLVM 16.0.X Release

Comments

@thesamesam
Copy link
Member

thesamesam commented May 13, 2023 •
edited
Loading

See #57740 and #24952.

Without this, LLVM is miscompiled (because of UB in User.cpp) when built with GCC LTO. Given that -fno-lifetime-dse is a GCC only flag and we know it was miscompiled otherwise with GCC LTO, I think we can safely backport it.

Needs 626849c and 47f5c54.
@thesamesam thesamesam added cmake Build system in general and CMake in particular release:backport llvm:optimizations LTO Link time optimization (regular/full LTO or ThinLTO) labels May 13, 2023
@thesamesam thesamesam added this to the LLVM 16.0.X Release milestone May 13, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented May 13, 2023

/branch llvm/llvm-project-release-prs/issue62699

@llvmbot llvmbot mentioned this issue May 13, 2023
Merged
@llvmbot
Copy link
Collaborator

llvmbot commented May 13, 2023

/pull-request llvm/llvm-project-release-prs#445

@EugeneZelenko EugeneZelenko removed llvm:optimizations LTO Link time optimization (regular/full LTO or ThinLTO) labels May 14, 2023
@thesamesam
Copy link
Member Author

/cherry-pick ce990b5

@thesamesam thesamesam changed the title Backport UB workaround (94f7c961c78d8fdbc05898cfbbf88094de45c1ad) for GCC LTO builds Backport UB workaround (ce990b542617e5b52f69707b103a2424bec5e53b) for GCC LTO builds May 14, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented May 14, 2023

/branch llvm/llvm-project-release-prs/issue62699

@thesamesam
Copy link
Member Author

/cherry-pick 626849c 47f5c54

@thesamesam thesamesam changed the title Backport UB workaround (ce990b542617e5b52f69707b103a2424bec5e53b) for GCC LTO builds Backport UB workaround for GCC LTO builds May 15, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented May 15, 2023

/branch llvm/llvm-project-release-prs/issue62699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake Build system in general and CMake in particular release:backport release:merged
Projects
LLVM Release Status
Archived in project
Milestone
LLVM 16.0.X Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#62699 llvm/llvm-project-release-prs
3 participants
@EugeneZelenko @thesamesam @llvmbot