clang-format does not format RawString text protos correctly when there is TextProto specific config.

[Icantjuddle]

Given the following c++ code:

#include <string>
namespace {
std::string string = R"pb(
  my_msg {
    item: "asdfasdfasdfasdfasdfasdfsadf"
    item_three: "asdfasdfasdfasdfasdfasdfas"
    item_two: "asdadsadfsafdsafdsadfsafds"
  }
)pb";
}

It will format differently with no logical difference in the .clang-format

With just BasedOnStyle: Google it will format as above.

With the following:

---
BasedOnStyle: Google
---
Language: TextProto
...

I would expect it to format as above, however, instead it will format as:

#include <string>
namespace {
std::string string = R"pb(
  my_msg {
    item : "asdfasdfasdfasdfasdfasdfsadf"
    item_three : "asdfasdfasdfasdfasdfasdfas"
    item_two : "asdadsadfsafdsafdsadfsafds"
  }
)pb";
}

Re-pro unittest.

[llvmbot]

@llvm/issue-subscribers-clang-format

[HazardyKnusperkeks]

And with

---
BasedOnStyle: Google
---
Language: TextProto
BasedOnStyle: Google
...

?

I think the error is in your assumption, not in Clang-Format.

[Icantjuddle]

I think the error is in your assumption, not in clang-format.

Definitely possible, maybe you can help me better understand.
I think my core assumption is that the Language: X item at the beginning of a section means "all following configuration options in this section will only affect X language formatting, but by itself will not change anything."
Thus, adding an empty Language: X section should do nothing.

And with

With your suggested .clang_format it still formats with the spaces preceding the :s.

[HazardyKnusperkeks]

I think the error is in your assumption, not in clang-format.

Definitely possible, maybe you can help me better understand. I think my core assumption is that the Language: X item at the beginning of a section means "all following configuration options in this section will only affect X language formatting, but by itself will not change anything." Thus, adding an empty Language: X section should do nothing.

And with

With your suggested .clang_format it still formats with the spaces preceding the :s.

That and krasimirs comment says it's a bug.