Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir] sort the operands of Commutative operations as part of CSE in a deterministic way #63784

Open
tomnatan opened this issue Jul 10, 2023 · 1 comment
Open

[mlir] sort the operands of Commutative operations as part of CSE in a deterministic way #63784

tomnatan opened this issue Jul 10, 2023 · 1 comment
Labels
mlir:core MLIR Core Infrastructure

Comments

@tomnatan
Copy link

D123492 added the ability to remove commutative operations but had a correctness issue since it sorted operands that are op results based on their pointers, which could cause identical regions to be considered not equivalent. D154699 reverted this change to fix the correctness issue. Instead, we should sort operands of Commutative operations in a determinstic way during CSE.
@EugeneZelenko EugeneZelenko added mlir:core MLIR Core Infrastructure and removed new issue labels Jul 10, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 10, 2023

@llvm/issue-subscribers-mlir-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mlir:core MLIR Core Infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EugeneZelenko @tomnatan @llvmbot