Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lit feature "reverse_iteration" #64085

Open
MaskRay opened this issue Jul 24, 2023 · 2 comments
Open

Remove lit feature "reverse_iteration" #64085

MaskRay opened this issue Jul 24, 2023 · 2 comments

Comments

@MaskRay
Copy link
Member

MaskRay commented Jul 24, 2023

I added a lit feature reverse_iteration to work around two tests when implementing LLVM_ENABLE_REVERSE_ITERATION for StringMap and changing StringMap used hash function from xxHash64 to xxh3_64bits. We can remove the lit feature once the following 2 tests are fixed:

% rg ':.*reverse_iteration'
llvm/test/ExecutionEngine/RuntimeDyld/ARM/MachO_ARM_PIC_relocations.s
1:# REQUIRES: reverse_iteration

llvm/test/CodeGen/MIR/AMDGPU/virtreg-uses-unallocatable-class.mir
1:# UNSUPPORTED: reverse_iteration

@jayfoad @lhames

@lhames
Copy link
Contributor

lhames commented Jul 24, 2023

I haven't had a chance to check the RuntimeDyld failure yet, and probably won't for a while.

Unless this is high priority I'm inclined to let it die off with RuntimeDyld -- I'm hoping that we can announce deprecation of it (and MCJIT) at the dev meeting this year, and maybe remove it next year or the year after.

@MaskRay
Copy link
Member Author

MaskRay commented Jul 24, 2023

Thank you for the response! You may consider removing llvm/test/ExecutionEngine/RuntimeDyld/ARM/MachO_ARM_PIC_relocations.s then, before the code becomes more dead...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants