Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like llvmbot stopped to remove awaiting-review labels after issue closed #64708

Open
EugeneZelenko opened this issue Aug 15, 2023 · 3 comments
Labels
infrastructure Bugs about LLVM infrastructure

Comments

@EugeneZelenko
Copy link
Contributor

See #35857 as example. At least 7 hours were passed after issue was closed and label was removed manually.

@EugeneZelenko EugeneZelenko added the infrastructure Bugs about LLVM infrastructure label Aug 15, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Aug 15, 2023

@llvm/issue-subscribers-infrastructure

@tungbq
Copy link

tungbq commented Aug 15, 2023

I have a look at the issue and it's caused by this commit: 06a9975 on Jun 28 (Temporary switch off labeler on closed issues)
I'm not sure about the reason that we disable the workflow on issue events. But I'm willing to enable it again if needed

@asl
Copy link
Collaborator

asl commented Aug 15, 2023

I have a look at the issue and it's caused by this commit: 06a9975 on Jun 28 (Temporary switch off labeler on closed issues) I'm not sure about the reason that we disable the workflow on issue events. But I'm willing to enable it again if needed

Please do not. The labeller action is racy – it just sets labels, it cannot add / remove them. There were complains that the labels that were set after the issue was closed were removed by labeller.

The labeller is not maintained anymore. And we need other solution using newer GH API at allows to add / remove labels (instead of setting all of them together).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Bugs about LLVM infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants